[
https://issues.apache.org/jira/browse/CASSANDRA-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240150#comment-15240150
]
Yuki Morishita commented on CASSANDRA-5977:
-------------------------------------------
Thanks for update. Overall, we are in the right direction.
Couple of comments:
* I think you don't need to use {{EMPTY}} from commons-lang3. Just use {{""}}
instead, and you can check it with {{String#isEmpty()}}.
* New {{StatsKeyspace}} and existing {{KeyspaceStats}} look almost the same.
can you merge those two?
And this one is debatable, but the format of JSON(and yaml) I prefer:
{code:javascript}
{
"system": {
"tables": {
"local": {
"...": 1,
}
}
}
}
{code}
to what the patch output now:
{code:javascript}
{
"keyspaces": [
{
"name": "system",
"tables": [
{
"name": "local",
}
]
}
]
}
{code}
WDYT?
Is it doable to print out the former?
> Structure for cfstats output (JSON, YAML, or XML)
> -------------------------------------------------
>
> Key: CASSANDRA-5977
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5977
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Alyssa Kwan
> Assignee: Shogo Hoshii
> Priority: Minor
> Labels: Tools
> Fix For: 3.x
>
> Attachments: CASSANDRA-5977-trunk.patch, sample_result.zip,
> tablestats_sample_result.json, tablestats_sample_result.txt,
> tablestats_sample_result.yaml, trunk-tablestats.patch, trunk-tablestats.patch
>
>
> nodetool cfstats should take a --format arg that structures the output in
> JSON, YAML, or XML. This would be useful for piping into another script that
> can easily parse this and act on it. It would also help those of us who use
> things like MCollective gather aggregate stats across clusters/nodes.
> Thoughts? I can submit a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
