[
https://issues.apache.org/jira/browse/CASSANDRA-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241872#comment-15241872
]
Ben Manes commented on CASSANDRA-11452:
---------------------------------------
Thanks. I won't have the bandwidth to test this until the evening. Roy flew
into SF for a conference (from Israel) so we're going to meet. If you have any
questions for me to discuss with him I'll proxy.
A quick glance and your trick has a nice distribution. A 1M iteration into a
multiset showed,
[0 x 750485, 1 x 186958, 2 x 46910, 3 x 11731, 4 x 2901, 5 x 776, 6 x 171, 7 x
49, 8 x 15, 9 x 3, 11]
I'd probably jitter when as the selection of the victim near the top of the
loop and add a check to handle zero weight entries. I'll take care of that part.
It seems like we'd need both your jitter and the hash check added in the prior
commit. It does sound that the combination would be an effective guard against
this type of attack. Do you think the random seed used by the sketch is still a
good addition?
> Cache implementation using LIRS eviction for in-process page cache
> ------------------------------------------------------------------
>
> Key: CASSANDRA-11452
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11452
> Project: Cassandra
> Issue Type: Improvement
> Components: Local Write-Read Paths
> Reporter: Branimir Lambov
> Assignee: Branimir Lambov
>
> Following up from CASSANDRA-5863, to make best use of caching and to avoid
> having to explicitly marking compaction accesses as non-cacheable, we need a
> cache implementation that uses an eviction algorithm that can better handle
> non-recurring accesses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
