[
https://issues.apache.org/jira/browse/CASSANDRA-11621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-11621:
------------------------------------
Status: Patch Available (was: Open)
>From Guava iterators documentation:
bq. the current implementation is not suitable for nested concatenated
iterators, i.e. the following should be avoided when in a loop: {{iterator =
Iterators.concat(iterator, suffix)}}, since iteration over the
resulting iterator has a cubic complexity to the depth of the nesting.
Patch proposes concatenating iterables all together at once. {{3.x}} and
{{trunk}} use same schema as proposed in this PR, although since all fields are
final there in {{ModificationStatement}}, there's no need to do the null
checks. There's also
[#11593|https://issues.apache.org/jira/browse/CASSANDRA-11593] which improves
the situation with iterables even further.
Code:
|[trunk|https://github.com/ifesdjeen/cassandra/tree/11621-2.2]|[dtest|https://github.com/ifesdjeen/cassandra-dtest/tree/11621-2.2]|
dtests (for 2.2, 3.0 and trunk, to make sure new dtests are passing for the
existing code):
|[2.2|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11621-2.2-dtest/]|[3.0|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11621-3.0-dtest/]
|[trunk|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11621-trunk-dtest/]
|
Unit tests (only 2.2 code was modified)
|[2.2|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11621-2.2-testall/]|
> Stack Overflow inserting value with many columns
> ------------------------------------------------
>
> Key: CASSANDRA-11621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11621
> Project: Cassandra
> Issue Type: Bug
> Environment: CQL 3
> C* 2.2.5
> Reporter: Andrew Jefferson
> Assignee: Alex Petrov
> Fix For: 2.2.x
>
>
> I am using CQL to insert into a table that has ~4000 columns
> {code}
> TABLE_DEFINITION = "
> id uuid,
> "dimension_n" for n in _.range(N_DIMENSIONS)
> ETAG timeuuid,
> PRIMARY KEY (id)
> "
> {code}
> I am using the node.js library from Datastax to execute CQL. This creates a
> prepared statement and then uses it to perform an insert. It works fine on C*
> 2.1 but after upgrading to C* 2.2.5 I get the stack overflow below.
> I know enough Java to think that recursing an iterator is bad form and should
> be easy to fix.
> {code}
> ERROR 14:59:01 Unexpected exception during request; channel = [id:
> 0xaac42a5d, /10.0.7.182:58736 => /10.0.0.87:9042]
> java.lang.StackOverflowError: null
> at
> com.google.common.base.Preconditions.checkPositionIndex(Preconditions.java:339)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.AbstractIndexedListIterator.<init>(AbstractIndexedListIterator.java:69)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$11.<init>(Iterators.java:1048)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators.forArray(Iterators.java:1048)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.RegularImmutableList.listIterator(RegularImmutableList.java:106)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.ImmutableList.listIterator(ImmutableList.java:344)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.ImmutableList.iterator(ImmutableList.java:340)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.ImmutableList.iterator(ImmutableList.java:61)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterables.iterators(Iterables.java:504)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterables.access$100(Iterables.java:60)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterables$2.iterator(Iterables.java:494)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterables$3.transform(Iterables.java:508)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterables$3.transform(Iterables.java:505)
> ~[guava-16.0.jar:na]
> at
> com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> ...
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at com.google.common.collect.Iterators$5.hasNext(Iterators.java:542)
> ~[guava-16.0.jar:na]
> at
> org.apache.cassandra.cql3.statements.ModificationStatement.checkAccess(ModificationStatement.java:168)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.QueryProcessor.processStatement(QueryProcessor.java:223)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:257)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.QueryProcessor.process(QueryProcessor.java:242)
> ~[main/:na]
> at
> org.apache.cassandra.transport.messages.QueryMessage.execute(QueryMessage.java:123)
> ~[main/:na]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:507)
> [main/:na]
> at
> org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:401)
> [main/:na]
> at
> io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
> [netty-all-4.0.23.Final.jar:4.0.23.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:333)
> [netty-all-4.0.23.Final.jar:4.0.23.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext.access$700(AbstractChannelHandlerContext.java:32)
> [netty-all-4.0.23.Final.jar:4.0.23.Final]
> at
> io.netty.channel.AbstractChannelHandlerContext$8.run(AbstractChannelHandlerContext.java:324)
> [netty-all-4.0.23.Final.jar:4.0.23.Final]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_77]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:164)
> [main/:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105)
> [main/:na]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_77]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
