[ 
https://issues.apache.org/jira/browse/CASSANDRA-11628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256399#comment-15256399
 ] 

Yuki Morishita commented on CASSANDRA-11628:
--------------------------------------------

||branch||dtest||
|[11628-2.1|https://github.com/yukim/cassandra/tree/11628-2.1]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11628-2.1-dtest/lastCompletedBuild/testReport/]|
|[11628-2.2|https://github.com/yukim/cassandra/tree/11628-2.2]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11628-2.2-dtest/lastCompletedBuild/testReport/]|
|[11628-3.0|https://github.com/yukim/cassandra/tree/11628-3.0]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11628-3.0-dtest/lastCompletedBuild/testReport/]|
|[11628-trunk|https://github.com/yukim/cassandra/tree/11628-trunk]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11628-trunk-dtest/lastCompletedBuild/testReport/]|

I created patch for 2.1, 2.2 and 3.0 as well.
Tests that covers those script change look good.

> Fix the regression to CASSANDRA-3983 that got introduced by CASSANDRA-10679
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11628
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11628
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Wei Deng
>            Assignee: Wei Deng
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>
> It appears that the commit from CASSANDRA-10679 accidentally cancelled out 
> the effect that was originally intended by CASSANDRA-3983. In this case, we 
> would like to address the following situation:
> When you already have a C* package installed (which will deploy a file as 
> /usr/share/cassandra/cassandra.in.sh), but also attempt to run from a binary 
> download from http://cassandra.apache.org/download/, many tools like 
> cassandra-stress, sstablescrub, etal. will search the packaged dir 
> (/usr/share/cassandra/cassandra.in.sh) for 'cassandra.in.sh' before searching 
> the dir in your binary download or source build. We should reverse the order 
> of that search so it checks locally first. Otherwise you will encounter some 
> error like the following:
> {noformat}
> root@node0:~/apache-cassandra-3.6-SNAPSHOT# tools/bin/cassandra-stress -h
> Error: Could not find or load main class org.apache.cassandra.stress.Stress
> {noformat}
> {noformat}
> root@node0:~/apache-cassandra-3.6-SNAPSHOT# bin/sstableverify -h
> Error: Could not find or load main class 
> org.apache.cassandra.tools.StandaloneVerifier
> {noformat}
> The goal for CASSANDRA-10679 is still a good one: "For the most part all of 
> our shell scripts do the same thing, load the cassandra.in.sh and then call 
> something out of a jar. They should all look the same." But in this case, we 
> should correct them all to look the same but making them to look local dir 
> first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to