[
https://issues.apache.org/jira/browse/CASSANDRA-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256453#comment-15256453
]
Paulo Motta commented on CASSANDRA-11600:
-----------------------------------------
looks good, but we can probably remove the nested if-else-if by failing earlier
if {{[ $USING_G1 -ne 0 ] && [ "x$MAX_HEAP_SIZE" = "x" -o "x$HEAP_NEWSIZE" = "x"
]}}, and then you can only {{calculate_heap_sizes}} if {{[ "x$MAX_HEAP_SIZE" =
"x" ]}} (valid for G1 or non-g1). WDYT?
Also, can you make similar change on {{cassandra-env.ps1}}? If you don't have a
windows box for testing I can test it myself after you submit. Thanks!
> Don't require HEAP_NEW_SIZE to be set when using G1
> ---------------------------------------------------
>
> Key: CASSANDRA-11600
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11600
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Minor
> Fix For: 3.6, 3.0.x
>
>
> Although cassandra-env.sh doesn't set -Xmn (unless set in jvm.options) when
> using G1GC, it still requires that you set HEAP_NEW_SIZE and MAX_HEAP_SIZE
> together, and won't start until you do. Since we ignore that setting if
> you're using G1, we shouldn't require that the user set it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
