[ 
https://issues.apache.org/jira/browse/CASSANDRA-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256471#comment-15256471
 ] 

Paulo Motta commented on CASSANDRA-11548:
-----------------------------------------

vote was already called so it should be out in the next few days (this week for 
sure)

> Anticompaction not removing old sstables
> ----------------------------------------
>
>                 Key: CASSANDRA-11548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11548
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: 2.1.13
>            Reporter: Ruoran Wang
>            Assignee: Ruoran Wang
>             Fix For: 2.1.14
>
>         Attachments: 0001-cassandra-2.1.13-potential-fix.patch
>
>
> 1. 12/29/15 https://issues.apache.org/jira/browse/CASSANDRA-10831
> Moved markCompactedSSTablesReplaced out of the loop ```for (SSTableReader 
> sstable : repairedSSTables)```
> 2. 1/18/16 https://issues.apache.org/jira/browse/CASSANDRA-10829
> Added unmarkCompacting into the loop. ```for (SSTableReader sstable : 
> repairedSSTables)```
> I think the effect of those above change might cause the 
> markCompactedSSTablesReplaced fail on 
> DataTracker.java
> {noformat}
>            assert newSSTables.size() + newShadowed.size() == newSSTablesSize :
>                 String.format("Expecting new size of %d, got %d while 
> replacing %s by %s in %s",
>                           newSSTablesSize, newSSTables.size() + 
> newShadowed.size(), oldSSTables, replacements, this);
> {noformat}
> Since change CASSANDRA-10831 moved it out. This AssertError won't be caught, 
> leaving the oldsstables not removed. (Then this might cause row out of order 
> error when doing incremental repair if there are L1 un-repaired sstables.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to