[ 
https://issues.apache.org/jira/browse/CASSANDRA-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262219#comment-15262219
 ] 

Alex Petrov commented on CASSANDRA-10962:
-----------------------------------------

This happens because {{SystemKeyspace::discardCompactionsInProgress}} calls 
{{ColumnFamilyStore::truncateBlocking}} on {{compactions_in_progress}}.

I've prepared a patch that would skip snapshot creation for this particular 
case, as in the rest of cases we rely on {{auto_snapshot}} property, and 
override it only here (btw, {{auto_snapshot}} is {{true}} by default).

|[2.2|https://github.com/ifesdjeen/cassandra/tree/10962-2.2]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-10962-2.2-testall/]|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-10962-2.2-dtest/]|

> Cassandra should not create snapshot at restart for compactions_in_progress
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10962
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10962
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Ubuntu 14.04.3 LTS
>            Reporter: FACORAT
>            Assignee: Alex Petrov
>            Priority: Minor
>             Fix For: 2.2.x
>
>
> If auto_snapshot is set to true in cassandra.yaml, each time you restart 
> Cassandra, a snapshot is created for system.compactions_in_progress as the 
> table is truncated at cassandra start.
> However as datas in this table are temporary, Cassandra should not create 
> snapshot for this table (or maybe even for system.* tables). This will be 
> coherent with the fact that "nodetool listsnapshots" doesn't even list this 
> table.
> Exemple:
> {code}
> $ nodetool listsnapshots | grep compactions
> $ ls -lh 
> system/compactions_in_progress-55080ab05d9c388690a4acb25fe1f77b/snapshots/
> total 16K
> drwxr-xr-x 2 cassandra cassandra 4.0K Nov 30 13:12 
> 1448885530280-compactions_in_progress
> drwxr-xr-x 2 cassandra cassandra 4.0K Dec  7 15:36 
> 1449498977181-compactions_in_progress
> drwxr-xr-x 2 cassandra cassandra 4.0K Dec 14 18:20 
> 1450113621506-compactions_in_progress
> drwxr-xr-x 2 cassandra cassandra 4.0K Jan  4 12:53 
> 1451908396364-compactions_in_progress
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to