[ 
https://issues.apache.org/jira/browse/CASSANDRA-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262979#comment-15262979
 ] 

Tyler Hobbs commented on CASSANDRA-11352:
-----------------------------------------

Thanks for the patch!

I've started CI test runs here:
||branch||testall||dtest||
|[CASSANDRA-11352-trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-11352-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11352-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/thobbs/job/thobbs-CASSANDRA-11352-trunk-dtest]|

I made a couple of minor changes to the output for improved readability:
* Lowered the amount of padding to handle the max numbers that we could 
reasonably see
* Added spaces in between numbers and units.  I know that we don't use a space 
in log messages, but considering how dense the information is in stress output, 
I think it's better to maximize readability.

bq. Total GC time is in seconds while other GC measures are in milliseconds. 
This could be misleading, I'm waiting reviewer comment on this

I think this is fine.  I changed the unit to be "seconds" instead of just "s" 
to make sure this is clear.

> Include units of metrics in the cassandra-stress tool 
> ------------------------------------------------------
>
>                 Key: CASSANDRA-11352
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11352
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Rajath Subramanyam
>            Assignee: Giampaolo
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.x
>
>         Attachments: 
> [email protected]
>
>
> cassandra-stress in the Results section can have units for the metrics as an 
> improvement to make the tool more usable. 
> {noformat}
> Results:
> op rate                   : 14668 [READ:7334, WRITE:7334]
> partition rate            : 14668 [READ:7334, WRITE:7334]
> row rate                  : 14668 [READ:7334, WRITE:7334]
> latency mean              : 0.7 [READ:0.7, WRITE:0.7]
> latency median            : 0.6 [READ:0.6, WRITE:0.6]
> latency 95th percentile   : 0.8 [READ:0.8, WRITE:0.8]
> latency 99th percentile   : 1.2 [READ:1.2, WRITE:1.2]
> latency 99.9th percentile : 8.8 [READ:8.9, WRITE:9.0]
> latency max               : 448.7 [READ:162.3, WRITE:448.7]
> Total partitions          : 105612753 [READ:52805915, WRITE:52806838]
> Total errors              : 0 [READ:0, WRITE:0]
> total gc count            : 0
> total gc mb               : 0
> total gc time (s)         : 0
> avg gc time(ms)           : NaN
> stdev gc time(ms)         : 0
> Total operation time      : 02:00:00
> END
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to