[ 
https://issues.apache.org/jira/browse/CASSANDRA-11555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266528#comment-15266528
 ] 

Benjamin Lerer commented on CASSANDRA-11555:
--------------------------------------------

I am +1 if the tests are fine.
The 2 following nits can be fixed on commit:
* In the {{cassandra.yaml}} there are typos in: {{Default value ("auto") is 
1/256th of the the heap or 10MB, whichever is greater}} the {{the}} is repeated 
twice.
* I would use {{FileUtils.MB}} rather than {{1024 * 1024}} as it makes the code 
more readable in my opinion.

> Make prepared statement cache size configurable
> -----------------------------------------------
>
>                 Key: CASSANDRA-11555
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11555
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>              Labels: docs-impacting
>             Fix For: 3.x
>
>
> The prepared statement caches in {{org.apache.cassandra.cql3.QueryProcessor}} 
> are configured using the formula {{Runtime.getRuntime().maxMemory() / 256}}. 
> Sometimes applications may need more than that. Proposal is to make that 
> value configurable - probably also distinguish thrift and native CQL3 queries 
> (new applications don't need the thrift stuff).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to