[
https://issues.apache.org/jira/browse/CASSANDRA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268557#comment-15268557
]
Aleksey Yeschenko commented on CASSANDRA-9861:
----------------------------------------------
Looks all right to me. Only got some trivial syntactic nits, feel free to
ignore them or change on commit:
- in {{HeapUtils}} there is no need to wrap all the things in the try/catch
block, only the two {{logProcessOutput()}} calls should be in the block
- new lines incorrect/missing in {{getProceddIdFromJvmName()}} try/catch block
> When forcibly exiting due to OOM, we should produce a heap dump
> ---------------------------------------------------------------
>
> Key: CASSANDRA-9861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9861
> Project: Cassandra
> Issue Type: Bug
> Components: Lifecycle
> Reporter: Benedict
> Assignee: Benjamin Lerer
> Priority: Minor
> Labels: lhf
> Fix For: 2.2.x
>
> Attachments: 9861-2.2-V2.txt, 9861-2.2.txt
>
>
> CASSANDRA-7507 introduced earlier termination on encountering an OOM, due to
> lack of certainty about system state. However a side effect is that we never
> produce heap dumps on OOM. We should ideally try to produce one forcibly
> before exiting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
