[ 
https://issues.apache.org/jira/browse/CASSANDRA-9766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270101#comment-15270101
 ] 

Stefania commented on CASSANDRA-9766:
-------------------------------------

Thanks for the modifications.

It LGTM now, I just have two small suggestions and some nits:

* In {{ColumnIndex}} a method to reset the properties that change would have 
been enough, no need to pass in every time {{header, dataFile, 
descriptor.version, observers}} and probably not even 
{{getRowIndexEntrySerializer().indexInfoSerializer()}}. This way these fields 
can return to be final.  
* In BTW, {{columnIndexWriter}} can be created in the constructor so it too can 
be final. 
* Nit: {{indexSamples}} in {{ColumnIndex}} can be final.
* Nit: unused import in {{CompressedInputStream}}: {{java.util.zip.Checksum}}
* Nit: we can restore {{import java.util.\*}} in BTreeSet.java and {{import 
java.util.concurrent.\*}} in BufferPool.java

CI looks good as well:
* the 3 failing dtests also fail on trunk
* the failing utests are all timeouts except for one which also fails on trunk. 
The tests with timeout pass locally and there are timeouts on trunk too.


> Bootstrap outgoing streaming speeds are much slower than during repair
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-9766
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9766
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>         Environment: Cassandra 2.1.2. more details in the pdf attached 
>            Reporter: Alexei K
>            Assignee: T Jake Luciani
>              Labels: performance
>             Fix For: 3.x
>
>         Attachments: problem.pdf
>
>
> I have a cluster in Amazon cloud , its described in detail in the attachment. 
> What I've noticed is that we during bootstrap we never go above 12MB/sec 
> transmission speeds and also those speeds flat line almost like we're hitting 
> some sort of a limit ( this remains true for other tests that I've ran) 
> however during the repair we see much higher,variable sending rates. I've 
> provided network charts in the attachment as well . Is there an explanation 
> for this? Is something wrong with my configuration, or is it a possible bug?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to