[ 
https://issues.apache.org/jira/browse/CASSANDRA-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278336#comment-15278336
 ] 

Blake Eggleston commented on CASSANDRA-11705:
---------------------------------------------

To prevent {{addInitialDirectories}} from changing {{initialDirectories}} while 
it's making a copy to return. Since we copy on write the {{initialDirectories}} 
value, I could just grab a reference to {{initialDirectories}} at the top of 
{{getInitialDirectories}} and copy from that instead, although both are called 
infrequently enough that I don't think it would make a difference.

> clearSnapshots using Directories.dataDirectories instead of 
> CFS.initialDirectories
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11705
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11705
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.0.x, 3.x
>
>
> An oversight in CASSANDRA-10518 prevents snapshots created in data 
> directories defined outside of cassandra.yaml from being cleared by 
> {{Keyspace.clearSnapshots}}. {{ColumnFamilyStore.initialDirectories}} should 
> be used when finding snapshots to clear, not {{Directories.dataDirectories}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to