[ 
https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992576#comment-12992576
 ] 

Jonathan Ellis commented on CASSANDRA-2140:
-------------------------------------------

+1 to the approach.  a couple possible improvements:

- I think all the calls to sendRR(prod.getMessage(Gossiper..), endpoint, 
handler) can be replaced with sendRR(prod, endpoint, handler)?
- Let's make CMP less wasteful by giving initialcapacity of 2 (common case: 
everyone is on same versio -- it gets multipled by load factor, so 2 gets 
rounded down to 1) and making getMessage take an Integer (so we auto[un]box 
zero times instead of 4)


> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v1-0001-cache-versioned-messages-in-StorageProxy.txt, 
> v1-0002-fix-misspeeling.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned 
> messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to