[ 
https://issues.apache.org/jira/browse/CASSANDRA-11613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288655#comment-15288655
 ] 

Benjamin Lerer commented on CASSANDRA-11613:
--------------------------------------------

Thanks. :-)

The patch look good to me. Just 2 nits that can be fixed on commit:
* The {{AbstractType::freezeNestedMulticellTypes}} comment seems to be missing 
something.
* In the {{freezeNestedMulticellTypes}} methods of {{ListType}} and {{SetType}} 
the {{else}} can be removed as all the branches ends with a {{return}} 
statement.

> dtest failure in 
> upgrade_tests.cql_tests.TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk.more_user_types_test
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11613
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11613
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Russ Hatch
>            Assignee: Tyler Hobbs
>              Labels: dtest
>             Fix For: 3.6
>
>
> example failure:
> http://cassci.datastax.com/job/upgrade_tests-all-custom_branch_runs/8/testReport/upgrade_tests.cql_tests/TestCQLNodes2RF1_2_2_HEAD_UpTo_Trunk/more_user_types_test
> Failed on CassCI build upgrade_tests-all-custom_branch_runs #8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to