[
https://issues.apache.org/jira/browse/CASSANDRA-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296308#comment-15296308
]
Marcus Eriksson commented on CASSANDRA-11739:
---------------------------------------------
LGTM
small nits;
* we used to remove the sstables from the {{sstableMap}} that had disappeared
from disk, pushed a small fix for that here:
https://github.com/krummas/cassandra/commits/paulo/11739
* we had {{@SuppressWarnings("resource")}} on {{getAndReferenceSSTables}} - it
should probably stay on {{getActiveRepairedSSTableRefs}} now
* {{public synchronized Refs<SSTableReader> getActiveRepairedSSTableRefs(UUID
cfId)}} seems to have 1 space too little indentation
> Cache key references might cause OOM on incremental repair
> ----------------------------------------------------------
>
> Key: CASSANDRA-11739
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11739
> Project: Cassandra
> Issue Type: Bug
> Reporter: Paulo Motta
> Assignee: Paulo Motta
> Attachments: heapdump.png
>
>
> We keep {{SSTableReader}} references for the duration of the repair to
> anti-compact later, and their tidier keep references to cache keys to be
> invalidated which are only cleaned up by GC after repair is finished. These
> cache keys can accumulate while repair is being executed leading to OOM for
> large tables/keyspaces.
> Heap dump attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
