[
https://issues.apache.org/jira/browse/CASSANDRA-8844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307432#comment-15307432
]
Branimir Lambov commented on CASSANDRA-8844:
--------------------------------------------
Reviewed the commitlog part again, this is a much safer approach. The issues I
saw are relatively minor:
*
[{{CommitLogSegmentManagerCDC.allocate}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-878dc31866184d5ef750ccd9befc8382R100]
has some asymmetry that hints at a concurrency issue. Indeed, if one thread
sets {{atCapacity}} and another advances a segment with non-tracked data while
a third is stopped at line ~117, we will overrun the capacity by one segment.
I'm not sure this is such a big deal -- perhaps we should just document that
possibility and go on.
The alternative is to take your worst-case approach a little further -- add an
{{acceptsCDCMutations}} flag and set it when the segment is created or space is
freed, reserving the capacity. If the segment ends up not having any, release
the capacity at {{discard}}. This will simplify {{allocate}} as it won't need
to check {{atCapacity}} at all. You could also combine the two booleans into an
enum for the CDC mutations state of a segment: FORBIDDEN -> PERMITTED ->
CONTAINS.
*
[{{CommitLogSegmentManagerCDC.discard}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-878dc31866184d5ef750ccd9befc8382R63]
should swap the order of {{removeUnflushedSize}} and {{addFlushedSize}},
otherwise {{atCapacity}} may flip in-between when space isn't actually
available.
* [Stopping replay on
error|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-0a01d2ee3c5e4d183d9dc73f5e900163R50]
actually stops _segment_ replay on error, and allows the process to continue
with the next segment. The old code didn't do anything different, but we now
claim returning true stops replay which isn't entirely correct -- at the very
least we should state so in the comment, but I'd rather just remove that
option. The comment should also say that to fully stop replay one must throw an
exception (as {{CommitLogReplayer}} does).
* [Pre-2.1
replay|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-9fe0bd988c4fc47a022f589f5ad72b09R130]
should also set {{mutationLimit}} on the tracker.
*
[{{SimpleCachedBufferPool}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-7298664d3f49b2a705d1b4fafd0621b0R83]
should provide {{getThreadLocalReusableBuffer(int size)}} which should
automatically reallocate if the available size is less, and not expose a setter
at all.
*
[{{AbstractCommitLogSegmentManager.start}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-85e13493c70723764c539dd222455979R114]:
You can use {{AbstractCommitLogSegmentManager.this}} instead of explicitly
saving {{parent}}.
* [for each loop vs
{{forEach}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-05c1e4fd86fea19b8e0552b1f289be85R370]:
I'm not a big fan of these transformations. The way lambdas are currently
implemented the latter incurs an extra allocation -- it is not a showstopping
inefficiency, but since that isn't unequivocally better, I wouldn't change the
loops when it doesn't significantly improve readability.
*
[{{commitLogUpperBound}}|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:8844_review#diff-98f5acb96aa6d684781936c141132e2aR979]
is replaced incorrectly in comments.
> Change Data Capture (CDC)
> -------------------------
>
> Key: CASSANDRA-8844
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8844
> Project: Cassandra
> Issue Type: New Feature
> Components: Coordination, Local Write-Read Paths
> Reporter: Tupshin Harper
> Assignee: Joshua McKenzie
> Priority: Critical
> Fix For: 3.x
>
>
> "In databases, change data capture (CDC) is a set of software design patterns
> used to determine (and track) the data that has changed so that action can be
> taken using the changed data. Also, Change data capture (CDC) is an approach
> to data integration that is based on the identification, capture and delivery
> of the changes made to enterprise data sources."
> -Wikipedia
> As Cassandra is increasingly being used as the Source of Record (SoR) for
> mission critical data in large enterprises, it is increasingly being called
> upon to act as the central hub of traffic and data flow to other systems. In
> order to try to address the general need, we (cc [~brianmhess]), propose
> implementing a simple data logging mechanism to enable per-table CDC patterns.
> h2. The goals:
> # Use CQL as the primary ingestion mechanism, in order to leverage its
> Consistency Level semantics, and in order to treat it as the single
> reliable/durable SoR for the data.
> # To provide a mechanism for implementing good and reliable
> (deliver-at-least-once with possible mechanisms for deliver-exactly-once )
> continuous semi-realtime feeds of mutations going into a Cassandra cluster.
> # To eliminate the developmental and operational burden of users so that they
> don't have to do dual writes to other systems.
> # For users that are currently doing batch export from a Cassandra system,
> give them the opportunity to make that realtime with a minimum of coding.
> h2. The mechanism:
> We propose a durable logging mechanism that functions similar to a commitlog,
> with the following nuances:
> - Takes place on every node, not just the coordinator, so RF number of copies
> are logged.
> - Separate log per table.
> - Per-table configuration. Only tables that are specified as CDC_LOG would do
> any logging.
> - Per DC. We are trying to keep the complexity to a minimum to make this an
> easy enhancement, but most likely use cases would prefer to only implement
> CDC logging in one (or a subset) of the DCs that are being replicated to
> - In the critical path of ConsistencyLevel acknowledgment. Just as with the
> commitlog, failure to write to the CDC log should fail that node's write. If
> that means the requested consistency level was not met, then clients *should*
> experience UnavailableExceptions.
> - Be written in a Row-centric manner such that it is easy for consumers to
> reconstitute rows atomically.
> - Written in a simple format designed to be consumed *directly* by daemons
> written in non JVM languages
> h2. Nice-to-haves
> I strongly suspect that the following features will be asked for, but I also
> believe that they can be deferred for a subsequent release, and to guage
> actual interest.
> - Multiple logs per table. This would make it easy to have multiple
> "subscribers" to a single table's changes. A workaround would be to create a
> forking daemon listener, but that's not a great answer.
> - Log filtering. Being able to apply filters, including UDF-based filters
> would make Casandra a much more versatile feeder into other systems, and
> again, reduce complexity that would otherwise need to be built into the
> daemons.
> h2. Format and Consumption
> - Cassandra would only write to the CDC log, and never delete from it.
> - Cleaning up consumed logfiles would be the client daemon's responibility
> - Logfile size should probably be configurable.
> - Logfiles should be named with a predictable naming schema, making it
> triivial to process them in order.
> - Daemons should be able to checkpoint their work, and resume from where they
> left off. This means they would have to leave some file artifact in the CDC
> log's directory.
> - A sophisticated daemon should be able to be written that could
> -- Catch up, in written-order, even when it is multiple logfiles behind in
> processing
> -- Be able to continuously "tail" the most recent logfile and get
> low-latency(ms?) access to the data as it is written.
> h2. Alternate approach
> In order to make consuming a change log easy and efficient to do with low
> latency, the following could supplement the approach outlined above
> - Instead of writing to a logfile, by default, Cassandra could expose a
> socket for a daemon to connect to, and from which it could pull each row.
> - Cassandra would have a limited buffer for storing rows, should the listener
> become backlogged, but it would immediately spill to disk in that case, never
> incurring large in-memory costs.
> h2. Additional consumption possibility
> With all of the above, still relevant:
> - instead (or in addition to) using the other logging mechanisms, use CQL
> transport itself as a logger.
> - Extend the CQL protoocol slightly so that rows of data can be return to a
> listener that didn't explicit make a query, but instead registered itself
> with Cassandra as a listener for a particular event type, and in this case,
> the event type would be anything that would otherwise go to a CDC log.
> - If there is no listener for the event type associated with that log, or if
> that listener gets backlogged, the rows will again spill to the persistent
> storage.
> h2. Possible Syntax
> {code:sql}
> CREATE TABLE ... WITH CDC LOG
> {code}
> Pros: No syntax extesions
> Cons: doesn't make it easy to capture the various permutations (i'm happy to
> be proven wrong) of per-dc logging. also, the hypothetical multiple logs per
> table would break this
> {code:sql}
> CREATE CDC_LOG mylog ON mytable WHERE MyUdf(mycol1, mycol2) = 5 with
> DCs={'dc1','dc3'}
> {code}
> Pros: Expressive and allows for easy DDL management of all aspects of CDC
> Cons: Syntax additions. Added complexity, partly for features that might not
> be implemented
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
