[ 
https://issues.apache.org/jira/browse/CASSANDRA-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322357#comment-15322357
 ] 

Marcus Eriksson commented on CASSANDRA-11944:
---------------------------------------------

Maybe you were looking at the wrong commit? I have rebased and squashed 
[here|https://github.com/krummas/cassandra/commits/marcuse/intervaltreesstableset]
{code}
-    public Collection<SSTableReader> getOverlappingSSTables(SSTableSet 
sstableSet, Iterable<SSTableReader> sstables)
+    public Collection<SSTableReader> 
getOverlappingSSTables(Iterable<SSTableReader> sstables)
{code}

> sstablesInBounds might not actually give all sstables within the bounds due 
> to having start positions moved in sstables
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11944
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11944
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.0.x, 3.x
>
>
> Same problem as with CASSANDRA-11886 - if we try to fetch sstablesInBounds 
> for CANONICAL_SSTABLES, we can miss some actually overlapping sstables. In 
> 3.0+ we state which SSTableSet we want when calling the method.
> Looks like the only issue this could cause is that we include a few too many 
> sstables in compactions that we think contain only droppable tombstones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to