[
https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335667#comment-15335667
]
Alex Petrov commented on CASSANDRA-11868:
-----------------------------------------
You're right, there's no overlap.
I suggest to only do the import changes in this patch: no annotation flag
changes or unused constant changes. If that's the largest problem there is
right now. Having a separate patch for each problem will make it easier to look
at the logs.
We need to rebase and re-run tests now. Other than that - I like the change.
> unused imports and generic types
> --------------------------------
>
> Key: CASSANDRA-11868
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11868
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
> Fix For: 3.8
>
>
> I was going through Cassandra source and for busy work I started looking at
> all the .java files eclipse flags as warning. They are broken roughly into a
> few cases.
> 1) unused imports
> 2) raw types missing <>
> 3) case statements without defaults
> 4) @resource annotation
> My IDE claims item 4 is not needed (it looks like we have done this to
> signify methods that return objects that need to be closed) I can guess 4 was
> done intentionally and short of making out own annotation I will ignore these
> for now.
> I would like to tackle this busy work before I get started. I have some
> questions:
> 1) Do this only on trunk? or multiple branches
> 2) should I tackle 1,2,3 in separate branches/patches
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
