[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343937#comment-15343937
]
Benjamin Lerer commented on CASSANDRA-9507:
-------------------------------------------
Thanks for the quick update.
It seems to me that patch for 3.x will not work.
{{RequestExecutionException}} extends {{RuntimeException}} which means that you
cannot rely anymore on the method declaration to know which
{{RequestExecutionExceptions}} are thrown.
{{StorageProxy::getRangeSlice}} do not throw those exceptions and they should
be removed from the method signature. I believe that they are thrown by the
returned {{RangeCommandIterator}} but I just looked at {{UnavailableException}}.
Otherwise, your patch for 2.2 does not handle {{ReadFailureException}} and the
{{final}} keywords in the {{catch}} blocks can be removed.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
> Reporter: sankalp kohli
> Assignee: Nachiket Patil
> Priority: Minor
> Attachments: CASSANDRA-9507 v2.X.diff, CASSANDRA-9507 v3.0-trunk.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
