[
https://issues.apache.org/jira/browse/CASSANDRA-11937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346958#comment-15346958
]
Alex Petrov commented on CASSANDRA-11937:
-----------------------------------------
> I think reuse() should call cleanup() too since it previously did both
Added call to `cleanup` from `reuse`. When recycling the object, `cleanup` will
now be called before we put it to recycler and after we get a recycled object.
Also, re-running all tests just in case:
|[trunk|https://github.com/ifesdjeen/cassandra/tree/11937-trunk]|[utest|http://cassci.datastax.com/job/ifesdjeen-11937-trunk-testall/1/]|[dtest|http://cassci.datastax.com/job/ifesdjeen-11937-trunk-dtest/1/]|[offheap
memtable
dtests|http://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11937-trunk-offheap-dtest/]|
> Clean up buffer trimming large buffers in DataOutputBuffer after the Netty
> upgrade
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-11937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11937
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Labels: lhf, netty, reminder
> Attachments: Screen Shot 2016-06-22 at 15.24.05.png
>
>
> In [https://issues.apache.org/jira/browse/CASSANDRA-11838|11838], we're
> trimming the large buffers in {{DataOutputBuffer}}. The patch is already
> submitted and merged in [Netty
> 4.1|https://github.com/netty/netty/commit/bbed330468b5b82c9e4defa59012d0fcdb70f1aa],
> we only need to make sure that we throw large buffers away1 alltogether
> instead of trimming them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
