[ 
https://issues.apache.org/jira/browse/CASSANDRA-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995545#comment-12995545
 ] 

Nick Bailey commented on CASSANDRA-1427:
----------------------------------------

* In requestRanges, instead of passing a request count you should just use the 
same strategy that streamRanges uses for counting down the latch.
* Hmm, I didn't notice this before but the fact that the new token in 
loadbalance is calculated before the move changes things pretty significantly.  
The fact that it left the ring before calculating a new token meant that it 
would consider the load it was giving away when trying to pick a new token. 
Honestly maybe we should just get rid of loadbalance since this a major version 
change. If someone wants load balance they can manually decommission then 
bootstrap. We should probably get someone else's opinion here.
* I've got to wonder if there is a better way to test this kind of stuff. 
(Move/Remove/LeaveAndBootstrap)Test are all kind of ridiculous (It's sad that I 
wrote one of them). Maybe we just need a separate task for figuring that out. 
Also perhaps a ticket for making/updating the distributed test for this.

> Optimize loadbalance/move for moves within the current range
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-1427
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1427
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Nick Bailey
>            Assignee: Pavel Yaskevich
>             Fix For: 0.8
>
>         Attachments: CASSANDRA-1427-v2.patch, CASSANDRA-1427-v3.patch, 
> CASSANDRA-1427-v4.patch, CASSANDRA-1427.patch
>
>   Original Estimate: 42h
>          Time Spent: 42h
>  Remaining Estimate: 0h
>
> Currently our move/loadbalance operations only implement case 2 of the Ruhl 
> algorithm described at 
> https://issues.apache.org/jira/browse/CASSANDRA-192#action_12713079.
> We should add functionality to optimize moves that take/give ranges to a 
> node's direct neighbors.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to