[
https://issues.apache.org/jira/browse/CASSANDRA-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joshua McKenzie updated CASSANDRA-11996:
----------------------------------------
Comment: was deleted
(was: bq. Shouldn't we only return the canonical sstables that are passed into
select as a parameter?
true, argh.. this approach wont work at all - the sstables passed in do not
contain the original version of the sstable, JUST the early opened one when we
are finishing up the compaction...
bq. In the test, don't we need to call
DatabaseDescriptor.setSSTablePreempiveOpenIntervalInMB()
no, this happens since we always open an "early" sstable when finishing writing
an sstable
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L316
- the {{setPreemptive...}} i had in the finally clause was a copy and paste
leftover)
> SSTableSet.CANONICAL can miss sstables
> --------------------------------------
>
> Key: CASSANDRA-11996
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11996
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Critical
> Fix For: 3.0.x, 3.x
>
>
> There is a race where we might miss sstables in SSTableSet.CANONICAL when we
> finish up a compaction.
> Reproducing unit test pushed
> [here|https://github.com/krummas/cassandra/commit/1292aaa61b89730cff0c022ed1262f45afd493e5]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
