[
https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362561#comment-15362561
]
Marcus Eriksson commented on CASSANDRA-7019:
--------------------------------------------
code LGTM, just a few comments;
* I don't see any unit tests using static rows or complex columns
* We need more code comments, especially in
{{GarbageSkippingUnfilteredRowIterator}} and the new methods in {{Cells}} and
{{Rows}}
* Could you add a dtest that runs {{nodetool garbagecollect}}?
* Add an explanation of the syntax in the CompactionIteratorTest ({{"5<=\[140\]
10\[150\] \[140\]<40 60\[150\]"}} for example) - it is quite confusing
otherwise :)
nit:
* some trailing whitespace in the patch [removed
here|https://github.com/krummas/cassandra/commit/0f1f9785fde67d24793b8ad93ade658afb98501a]
[~philipthompson] could we run all dtests with
-Ddefault.provide.overlapping.tombstones=ROW and
-Ddefault.provide.overlapping.tombstones=CELL once? (there might be some tests
where we assert that data is not removed during standard compaction, but we can
manually check those)
> Improve tombstone compactions
> -----------------------------
>
> Key: CASSANDRA-7019
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7019
> Project: Cassandra
> Issue Type: Improvement
> Components: Compaction
> Reporter: Marcus Eriksson
> Assignee: Branimir Lambov
> Labels: compaction, fallout
> Fix For: 3.x
>
> Attachments: 7019-2-system.log, 7019-debug.log, cell.tar.gz,
> control.tar.gz, none.tar.gz, row.tar.gz, temp-plot.html
>
>
> When there are no other compactions to do, we trigger a single-sstable
> compaction if there is more than X% droppable tombstones in the sstable.
> In this ticket we should try to include overlapping sstables in those
> compactions to be able to actually drop the tombstones. Might only be doable
> with LCS (with STCS we would probably end up including all sstables)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
