[
https://issues.apache.org/jira/browse/CASSANDRA-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363462#comment-15363462
]
Tyler Hobbs commented on CASSANDRA-9613:
----------------------------------------
I apologize for letting this sit in review for a while.
Overall, I think the patch is good. I have a few review comments:
* The reason for "UDAs only support UDFs" is pretty clear (the built-in
functions don't support non-serialized arguments), but I'm worried about
breaking compatibility here. It seems like it would be better to support
built-ins but take the performance hit and serialize arguments for now. Right
now it's probably not very common to use a built-in for the state function (I
can't think of any that make a lot of sense), so I think we can take our time
optimizing this case.
* It's a little hard to tell what's going on in {{generateArguments}}. That's
not a new thing, but it would be good to make it a little clearer now. Maybe
comments showing expected output?
* The new test is slightly confusing. I understand what it does now, but it
took me a minute to figure out. A quick comment explaining how it works would
be useful.
Other than that, can you rebase and start a final trunk test run?
> Omit (de)serialization of state variable in UDAs
> ------------------------------------------------
>
> Key: CASSANDRA-9613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9613
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 3.x
>
>
> Currently the result of each UDA's state function call is serialized and then
> deserialized for the next state-function invocation and optionally final
> function invocation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
