[
https://issues.apache.org/jira/browse/CASSANDRA-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382392#comment-15382392
]
Sylvain Lebresne commented on CASSANDRA-12144:
----------------------------------------------
Mostly look good, just a couple of nits:
* I'd rename {{MergingSStableIterator}} as "merging sstables" is a thing and
it's not at all what that class is doing. Call it maybe
{{RowMergingSSTableIterator}} or {{FixDuplicatedRowSSTableIterator}}? Also, as
that's pretty specific to scrub and we shouldn't be using that anywhere else,
so I'd maybe move that inside Scrubber (if we had a scrub package, i'd have
more it there, but we don't).
* Could maybe move the exception handling code of {{SSTableIdentityIterator}}
into some reusable function to avoid duplication.
* In the codebase, when a case of a {{if}} is short and exit from the control
flow, we tend to deal with it first to limit indentation. Concretely, I mean
that in {{MergingSSTableIterator.computeNext()}}, it'd be more idiomatic to the
codebase to do:
{noformat}
if (!iterator.next())
return endOfData();
Unfiltered next = iterator.next();
if (!next.isRow())
return next;
...
{noformat}
> Undeletable rows after upgrading from 2.2.4 to 3.0.7
> ----------------------------------------------------
>
> Key: CASSANDRA-12144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12144
> Project: Cassandra
> Issue Type: Bug
> Reporter: Stanislav Vishnevskiy
> Assignee: Alex Petrov
>
> We upgraded our cluster today and now have a some rows that refuse to delete.
> Here are some example traces.
> https://gist.github.com/vishnevskiy/36aa18c468344ea22d14f9fb9b99171d
> Even weirder.
> Updating the row and querying it back results in 2 rows even though the id is
> the clustering key.
> {noformat}
> user_id | id | since | type
> -------------------+--------------------+--------------------------+------
> 116138050710536192 | 153047019424972800 | null | 0
> 116138050710536192 | 153047019424972800 | 2016-05-30 14:53:08+0000 | 2
> {noformat}
> And then deleting it again only removes the new one.
> {noformat}
> cqlsh:discord_relationships> DELETE FROM relationships WHERE user_id =
> 116138050710536192 AND id = 153047019424972800;
> cqlsh:discord_relationships> SELECT * FROM relationships WHERE user_id =
> 116138050710536192 AND id = 153047019424972800;
> user_id | id | since | type
> --------------------+--------------------+--------------------------+------
> 116138050710536192 | 153047019424972800 | 2016-05-30 14:53:08+0000 | 2
> {noformat}
> We tried repairing, compacting, scrubbing. No Luck.
> Not sure what to do. Is anyone aware of this?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
