[
https://issues.apache.org/jira/browse/CASSANDRA-11850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387093#comment-15387093
]
Stefania commented on CASSANDRA-11850:
--------------------------------------
Thanks for the review.
bq. The 2.1 patch looks, can you just update to use the 2.7.2 zip now that #606
got in?
Done.
bq. Similarly, can you regenerate the 2.2+ cassandra-driver libs after #617 was
merged?
Done.
bq. I didn't get this change, is this related to this patch? won't
prev_worker_no=-1 and thus i=0 always?
Sorry I should have mentioned this. During debugging I noticed that failed
attempts were always sent to child process no. 0. This change ensures that
failed attempts are sent to the child process following the one that failed.
The worker no. is updated in the for loop and set to the worker the range is
sent to. So if we process the range twice, we should send it to the next worker
no.
bq. +1 to dtest and cdc-related changes (afaic)
Thanks, they should be straightforward.
bq. The original intent of test_refresh_schema_on_timeout_error on
CASSANDRA-9689 was to make sure a newly created keyspace/table will show up if
there is a down node during the DDL statement, but since down nodes no longer
causes schema mismatches after PYTHON-531 the schema mismatch assertions are no
longer necessary (even though we still need to keep the --request-timeout
option on 2.1 dtest to avoid flakiness - see CASSANDRA-10686), so I renamed the
test to test_update_schema_with_down_node. Here is the dtest branch with these
changes.
OK, thanks for the explanation.
{quote}
I also added a new commit with the following changes:
Refactor perform_simple_statement to always try to reload the schema if
there's a mismatch in order to cover both CASSANDRA-9689 and CASSANDRA-10686.
Remove the schema mismatch check on startup, since this is no longer
necessary after PYTHON-303.
Update the schema mismatch warning message
{quote}
Your changes LGTM, I've incorporated them into my branches.
bq. It would be nice to add a dtest to verify that the schema mismatch warning
is being print on a proper schema mismatch but I didn't find a simple way to
induce a schema mismatch without adding a special test flag on C* which is not
an ideal solution. I tested manually by disabling the schema_version update on
the system.peers table, and the warning is being printed correctly. We could
probably achieve that easily with byteman but since that is not yet integrated
with dtests let's maybe leave it for another ticket.
Thanks for the manual tests. Perhaps we can open a ticket to create a test once
byteman is integrated with dtests?
bq. Submitted multiplexer 100x runs for 2.1 and trunk so we can remove the
@known_failure annotations and close CASSANDRA-11999 and CASSANDRA-10884.
OK, I think you've already removed the known failures in you commit. I will
close those tickets when we commit this.
bq. It would be nice if you could maybe extract CASSANDRA-11979 to a separate
commit to improve traceability?
I've extracted the change and put it on a separate branch. Details are on
CASSANDRA-11979, I've put you as reviewer.
--
Here are the up-to-date branches and latest tests results:
||2.1||2.2||3.0||3.9||trunk||
|[patch|https://github.com/stef1927/cassandra/commits/11850-cqlsh-2.1]|[patch|https://github.com/stef1927/cassandra/commits/11850-cqlsh-2.2]|[patch|https://github.com/stef1927/cassandra/commits/11850-cqlsh-3.0]|[patch|https://github.com/stef1927/cassandra/commits/11850-cqlsh-3.9]|[patch|https://github.com/stef1927/cassandra/commits/11850-cqlsh]|
|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11850-cqlsh-2.1-cqlsh-tests/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11850-cqlsh-2.2-cqlsh-tests/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11850-cqlsh-3.0-cqlsh-tests/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11850-cqlsh-3.9-cqlsh-tests/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11850-cqlsh-cqlsh-tests/]|
> cannot use cql since upgrading python to 2.7.11+
> ------------------------------------------------
>
> Key: CASSANDRA-11850
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11850
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Environment: Development
> Reporter: Andrew Madison
> Assignee: Stefania
> Labels: cqlsh
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>
> OS: Debian GNU/Linux stretch/sid
> Kernel: 4.5.0-2-amd64 #1 SMP Debian 4.5.4-1 (2016-05-16) x86_64 GNU/Linux
> Python version: 2.7.11+ (default, May 9 2016, 15:54:33)
> [GCC 5.3.1 20160429]
> cqlsh --version: cqlsh 5.0.1
> cassandra -v: 3.5 (also occurs with 3.0.6)
> Issue:
> when running cqlsh, it returns the following error:
> cqlsh -u dbarpt_usr01
> Password: *****
> Connection error: ('Unable to connect to any servers', {'odbasandbox1':
> TypeError('ref() does not take keyword arguments',)})
> I cleared PYTHONPATH:
> python -c "import json; print dir(json); print json.__version__"
> ['JSONDecoder', 'JSONEncoder', '__all__', '__author__', '__builtins__',
> '__doc__', '__file__', '__name__', '__package__', '__path__', '__version__',
> '_default_decoder', '_default_encoder', 'decoder', 'dump', 'dumps',
> 'encoder', 'load', 'loads', 'scanner']
> 2.0.9
> Java based clients can connect to Cassandra with no issue. Just CQLSH and
> Python clients cannot.
> nodetool status also works.
> Thank you for your help.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
