[ 
https://issues.apache.org/jira/browse/CASSANDRA-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387442#comment-15387442
 ] 

Alex Petrov commented on CASSANDRA-12142:
-----------------------------------------

bq. If it's too high, we should respond with a protocol error message with 
CURRENT_VERSION, as we can't correctly respond with a higher version.

True. I agree here. My problem mainly was 
[here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/Frame.java#L238-L241].
 The simplest way to develop was by using {{SimpleClient}}, but it relies on 
the same mechanism as the server. When the exception is thrown and only 
protocol version is parsed, server would usually respond with the 
{{CURRENT_VERSION}}. In patch I still respond with {{5}}, as this is a valid 
version and was provided by the client. 

So I mostly wanted to highlight that and maybe explain 
[here|https://github.com/apache/cassandra/blob/trunk/doc/native_protocol_v4.spec#L99-L102]
 that there might be a response with servers' {{CURRENT_VERSION}} under some 
circumstances. Although it might be a bit too much detail.

> Add "beta" version native protocol flag
> ---------------------------------------
>
>                 Key: CASSANDRA-12142
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12142
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: CQL
>            Reporter: Tyler Hobbs
>            Assignee: Alex Petrov
>              Labels: protocolv5
>
> As discussed in CASSANDRA-10786, we'd like to add a new flag to the native 
> protocol to allow drivers to connect using a "beta" native protocol version.  
> This would be used for native protocol versions that are still in development 
> and may not have all of the final features.  Without the "beta" flag, drivers 
> will be prevented from using the protocol version.
> This is primarily useful for driver authors to start work against a new 
> protocol version when the work on that spans multiple releases.  Users would 
> not generally be expected to utilize this flag, although it could potentially 
> be used to offer early feedback on new protocol features.
> It seems like the {{STARTUP}} message body is the best place for the new beta 
> flag.  We may also considering adding protocol information to the 
> {{SUPPORTED}} message as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to