[
https://issues.apache.org/jira/browse/CASSANDRA-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387950#comment-15387950
]
Joshua McKenzie edited comment on CASSANDRA-12236 at 7/21/16 4:43 PM:
----------------------------------------------------------------------
We don't need to mess with null vs. empty set since cdc is a boolean on the
table level with the "v2" design and DC enabled/disabled is handled on the
consumer level. It already defaults to false in
{{SchemaKeyspace.createTableParamsFromRow}} for backwards compatibility from
older nodes.
Attaching a trivial patch to only add the param in
{{SchemaKeyspace.addTableParamsToSchemaMutation}} if cdc is enabled on the node.
Edit: Went ahead and pushed a branch so we can run CI against it and see how
things fare w/null in the cdc field:
||branch||testall||dtest||
|[12236|https://github.com/josh-mckenzie/cassandra/tree/12236]|[testall|http://cassci.datastax.com/view/Dev/view/josh-mckenzie/job/josh-mckenzie-12236-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/josh-mckenzie/job/josh-mckenzie-12236-dtest]|
[~philipthompson] / [~mambocab]: What are the chances we could get upgrade
tests run against the above branch?
was (Author: joshuamckenzie):
We don't need to mess with null vs. empty set since cdc is a boolean on the
table level with the "v2" design and DC enabled/disabled is handled on the
consumer level. It already defaults to false in
{{SchemaKeyspace.createTableParamsFromRow}} for backwards compatibility from
older nodes.
Attaching a trivial patch to only add the param in
{{SchemaKeyspace.addTableParamsToSchemaMutation}} if cdc is enabled on the node.
> RTE from new CDC column breaks in flight queries.
> -------------------------------------------------
>
> Key: CASSANDRA-12236
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12236
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jeremiah Jordan
> Assignee: Joshua McKenzie
> Fix For: 3.x
>
> Attachments: 12236.txt
>
>
> This RTE is not harmless. It will cause the internode connection to break
> which will cause all in flight requests between these nodes to die/timeout.
> {noformat}
> - Due to changes in schema migration handling and the storage format
> after 3.0, you will
> see error messages such as:
> "java.lang.RuntimeException: Unknown column cdc during
> deserialization"
> in your system logs on a mixed-version cluster during upgrades. This
> error message
> is harmless and due to the 3.8 nodes having cdc added to their schema
> tables while
> the <3.8 nodes do not. This message should cease once all nodes are
> upgraded to 3.8.
> As always, refrain from schema changes during cluster upgrades.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
