[ 
https://issues.apache.org/jira/browse/CASSANDRA-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390264#comment-15390264
 ] 

Paulo Motta commented on CASSANDRA-11465:
-----------------------------------------

While this looks good and seems to solve the problem, it may introduce timing 
dependencies between concurrent tracing sessions and the timeout would still 
not guarantee all messages are persisted before the tracing session completes. 
While this is probably not a big deal and much better than what we currently 
have, I think a more robust and deterministic approach would be to keep tracing 
futures for each {{TraceStateImpl}} and wait for them to complete before 
stopping the session. WDYT of this alternative approach? 

If the alternative is not feasible for some reason I'm not aware of, adds too 
much complexity, or requires a change of interfaces, I'm also fine with keeping 
the current approach and perhaps opening another ticket for improvement later 
if feasible.

> dtest failure in cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11465
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11465
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Stefania
>              Labels: dtest
>
> Failing on the following assert, on trunk only: 
> {{self.assertEqual(len(errs[0]), 1)}}
> Is not failing consistently.
> example failure:
> http://cassci.datastax.com/job/trunk_dtest/1087/testReport/cql_tracing_test/TestCqlTracing/tracing_unknown_impl_test
> Failed on CassCI build trunk_dtest #1087



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to