[ 
https://issues.apache.org/jira/browse/CASSANDRA-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402162#comment-15402162
 ] 

Paulo Motta commented on CASSANDRA-12348:
-----------------------------------------

+1, but {{validateCFS}} having side-effects is pretty counter-intuitive, so 
before committing can you maybe add a comment on this method warning that it 
should be typically called after the last test assertion?

> Flaky failures in SSTableRewriterTest.basicTest2/getPositionsTest
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-12348
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12348
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Joel Knighton
>            Assignee: Stefania
>             Fix For: 3.x
>
>
> Example failures:
> http://cassci.datastax.com/job/cassandra-3.9_testall/45/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/basicTest2/
> http://cassci.datastax.com/job/cassandra-3.9_testall/37/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> http://cassci.datastax.com/job/trunk_testall/1054/testReport/junit/org.apache.cassandra.io.sstable/SSTableRewriterTest/getPositionsTest/
> All failures look like the test is finding more files than expected after a 
> rewrite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to