[
https://issues.apache.org/jira/browse/CASSANDRA-9507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403562#comment-15403562
]
Alex Petrov commented on CASSANDRA-9507:
----------------------------------------
Yes, I meant we should leave it out for {{2.1}}. Sorry I forgot to mention the
version number, added now.
As regards the patch, I still can see Benjamin's comments there:
* {{final}} keywords in {{catch}} blocks in [3.0
patch|https://github.com/ifesdjeen/cassandra/commit/4e6a45a0ffc11a8e0589fd4b48d9d3850ed535ab#diff-71f06c193f5b5e270cf8ac695164f43aR2066]
(btw, it merges clean to trunk) (if it was the only thing we could just fix it
on commit)
* exceptions thrown in {{StorageProxy::getRangeSlice}} are [still
there|https://github.com/ifesdjeen/cassandra/blob/4e6a45a0ffc11a8e0589fd4b48d9d3850ed535ab/src/java/org/apache/cassandra/service/StorageProxy.java#L2165].
[~blerer] has suggested to remove them since they're not thrown there. As he
mentioned, for example, the {{UnavailableException}} is thrown in
{{RangeCommandIterator#query}} (since it calls {{assureSufficientLiveNodes}}
originally and bubbled up. As far as I can say, they're thrown in a different
way/different place in {{2.2}}.
> range metrics are not updated for timeout and unavailable in StorageProxy
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-9507
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9507
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
> Reporter: sankalp kohli
> Assignee: Nachiket Patil
> Priority: Minor
> Attachments: CASANDRA-9507 trunk.diff, CASSANDRA-9507 v2.1.diff,
> CASSANDRA-9507 v2.2.diff, CASSANDRA-9507 v3.0.diff
>
>
> Looking at the code, it looks like range metrics are not updated for timeouts
> and unavailable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
