[ 
https://issues.apache.org/jira/browse/CASSANDRA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407841#comment-15407841
 ] 

Robert Stupp commented on CASSANDRA-12381:
------------------------------------------

CI just triggered.

||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:12381-hasArray-isDirect-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-trunk-dtest/lastSuccessfulBuild/]
||cassandra-3.9|[branch|https://github.com/apache/cassandra/compare/cassandra-3.9...snazy:12381-hasArray-isDirect-3.9]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-3.9-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-3.9-dtest/lastSuccessfulBuild/]
||cassandra-3.0|[branch|https://github.com/apache/cassandra/compare/cassandra-3.0...snazy:12381-hasArray-isDirect-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-3.0-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-3.0-dtest/lastSuccessfulBuild/]
||cassandra-2.2|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...snazy:12381-hasArray-isDirect-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-2.2-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-2.2-dtest/lastSuccessfulBuild/]
||cassandra-2.1|[branch|https://github.com/apache/cassandra/compare/cassandra-2.1...snazy:12381-hasArray-isDirect-2.1]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-2.1-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-12381-hasArray-isDirect-2.1-dtest/lastSuccessfulBuild/]


> Verify use of ByteBuffer.hasArray() in whole code base
> ------------------------------------------------------
>
>                 Key: CASSANDRA-12381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12381
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 2.1.x
>
>
> As [noted 
> here|https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html#allocateDirect-int-],
>  a direct {{ByteBuffer}} can have a backing array.
> If a direct {{ByteBuffer}} has a backing array, we should not make any 
> assumption on how it is actually used.
> This ticket is about to check whether uses of {{ByteBuffer.hasArray()}} need 
> to be replaced with {{ByteBuffer.isDirect()}}.
> (With CASSANDRA-11870 however, there is no way that such a direct 
> {{ByteBuffer}} has a backing array.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to