[ 
https://issues.apache.org/jira/browse/CASSANDRA-9876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414245#comment-15414245
 ] 

Paulo Motta commented on CASSANDRA-9876:
----------------------------------------

Thanks for the patch! Overall this looks good and nearly ready, just a few 
minor nits to fix:
* Since {{pullRepair}} is coordinator-only, I think it's better to pass it 
directly to {{LocalSyncTask}} instead of passing it via {{RepairJobDesc}} which 
is also a remote object (I saw that you are not serializing it, but I think 
it's cleaner to keep this to the coordinator only to avoid confusion).
* since the command is already called repair, perhaps we should call the option 
{{\-\-pull}} instead of {{\-\-pull-repair}}?
* I don't think it's necessary to make specifying {{\-\-start-token}} and 
{{\-\-end-token}} mandatory, since if that is not specified it will just pull 
repair all common ranges between specified hosts.
* can you just a simple dtest on {{repair_tests/repair_test.py}} verifying this 
works?

> One way targeted repair
> -----------------------
>
>                 Key: CASSANDRA-9876
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9876
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: sankalp kohli
>            Assignee: Geoffrey Yu
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: 9876-trunk.txt
>
>
> Many applications use C* by writing to one local DC. The other DC is used 
> when the local DC is unavailable. When the local DC becomes available, we 
> want to run a targeted repair b/w one endpoint from each DC to minimize the 
> data transfer over WAN.  In this case, it will be helpful to do a one way 
> repair in which data will only be streamed from other DC to local DC instead 
> of streaming the data both ways. This will further minimize the traffic over 
> WAN. This feature should only be supported if a targeted repair is run 
> involving 2 hosts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to