Alex Petrov created CASSANDRA-12504:
---------------------------------------
Summary: BatchlogManager is shut down twice during drain
Key: CASSANDRA-12504
URL: https://issues.apache.org/jira/browse/CASSANDRA-12504
Project: Cassandra
Issue Type: Bug
Reporter: Alex Petrov
Priority: Minor
{{BatchlogManager}} is shut down twice during in the {{StorageService}}, once
[here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageService.java#L4216]
and once
[here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/StorageService.java#L4285].
The first shutdown was already there but the last one seems to have been added
[here|https://github.com/apache/cassandra/commit/53a177a9150586e56408f25c959f75110a2997e7#diff-b76a607445d53f18a98c9df14323c7ddR3913].
It seems to be harmless, as it’s not required in stages in-between, so second
run would be a no-op.
Following the logic of other shutdown hook, the first one is the good place for
it to be (right before {{HintsService}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
