[ 
https://issues.apache.org/jira/browse/CASSANDRA-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429283#comment-15429283
 ] 

Dikang Gu edited comment on CASSANDRA-6216 at 8/21/16 7:11 PM:
---------------------------------------------------------------

[~krummas] cool, I think it's a more easy-to-understand idea, and maybe could 
save a lot of code. Here is the patch 
https://github.com/DikangGu/cassandra/commit/3dfd0f29c9152bbe5283514f6f90886ebc2f87f1,
 can you please take a look?

I'm not sure how to write the unit test at this moment, will try some manual 
testing.


was (Author: dikanggu):
[~krummas] cool, I think it's a more easy-to-understand idea, and maybe could 
save a lot of code. Here is the patch 
https://github.com/DikangGu/cassandra/commit/a63c8583ada93187b177c68dbc4443c29717e44e,
 can you please take a look?

I'm not sure how to write the unit test at this moment, will try some manual 
testing.

> Level Compaction should persist last compacted key per level
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-6216
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6216
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: sankalp kohli
>            Assignee: Dikang Gu
>            Priority: Minor
>              Labels: compaction, lcs
>         Attachments: JIRA-6216.diff
>
>
> Level compaction does not persist the last compacted key per level. This is 
> important for higher levels. 
> The sstables with higher token and in higher levels wont get a chance to 
> compact as the last compacted key will get reset after a restart.    



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to