[
https://issues.apache.org/jira/browse/CASSANDRA-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435670#comment-15435670
]
Alex Petrov edited comment on CASSANDRA-11706 at 8/26/16 7:57 AM:
------------------------------------------------------------------
Thanks for the patch! +1 from my side.
I've triggered CI just in case, will transfer it to ready to commit when they
pass:
|[trunk patch |https://github.com/ifesdjeen/cassandra/tree/11706-trunk] |[dtest
patch|https://github.com/riptano/cassandra-dtest/pull/1281]|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11706-trunk-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11706-trunk-dtest/]
|
was (Author: ifesdjeen):
Thanks for the patch! +1 from my side.
I've triggered CI just in case, will transfer it to ready to commit when they
pass:
|[trunk |https://github.com/ifesdjeen/cassandra/tree/11706-trunk]
|[utest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11706-trunk-testall/]
|[dtest|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11706-trunk-dtest/]
|
> Tracing payload not passed through newSession(..)
> -------------------------------------------------
>
> Key: CASSANDRA-11706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11706
> Project: Cassandra
> Issue Type: Bug
> Reporter: mck
> Assignee: mck
> Priority: Minor
> Labels: tracing
> Fix For: 3.x
>
> Attachments: trunk-11706.txt
>
>
> Caused by CASSANDRA-10392
> There's a small bug in
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tracing/Tracing.java#L153
> {noformat}
> public UUID newSession(UUID sessionId, Map<String,ByteBuffer>
> customPayload)
> {
> return newSession(sessionId, TraceType.QUERY, Collections.EMPTY_MAP);
> }{noformat}
> in that it passes on an {{EMPTY_MAP}} instead of the {{customPayload}}.
> I've marked this as "minor" as custom tracing plugins can easily enough
> workaround it by also overriding the {{newSession(UUID sessionId,
> Map<String,ByteBuffer> customPayload)}} method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
