[
https://issues.apache.org/jira/browse/CASSANDRA-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489119#comment-15489119
]
Stefania commented on CASSANDRA-9318:
-------------------------------------
Thanks for the update, and for running the tests. Is it possible to attach some
test results?
Here is the code review, hopefully we are almost there:
* There is an NPE in {{RateBasedBackPressureTest}}, looks like we need to call
{{DatabaseDescriptor.daemonInitialization();}}.
* {{DatabaseDescriptorRefTest}} has two failures, I think we need to add the
new classes that get initialized by DD to the test white list.
* There are several failing dtests compared to trunk, it seems we have lots of
schema related issues. Can we rerun both jobs to see if this is a coincidence
or if we have an issue? This sort of errors appear on trunk as well, but they
are usually very rare and only 1 or 2 tests have schema issues, here we had
more than 10.
* Is [this
commit|https://github.com/apache/cassandra/commit/ad729f2d1758ec8c4add7b71ce3c3a680f5beb6d]
complete? It looks like {{AbstractWriteResponseHandler.start}} is not used.
* Trailing spaces (but they can be fixed on commit).
> Bound the number of in-flight requests at the coordinator
> ---------------------------------------------------------
>
> Key: CASSANDRA-9318
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9318
> Project: Cassandra
> Issue Type: Improvement
> Components: Local Write-Read Paths, Streaming and Messaging
> Reporter: Ariel Weisberg
> Assignee: Sergio Bossa
> Attachments: 9318-3.0-nits-trailing-spaces.patch, backpressure.png,
> limit.btm, no_backpressure.png
>
>
> It's possible to somewhat bound the amount of load accepted into the cluster
> by bounding the number of in-flight requests and request bytes.
> An implementation might do something like track the number of outstanding
> bytes and requests and if it reaches a high watermark disable read on client
> connections until it goes back below some low watermark.
> Need to make sure that disabling read on the client connection won't
> introduce other issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
