[
https://issues.apache.org/jira/browse/CASSANDRA-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491194#comment-15491194
]
Tyler Hobbs commented on CASSANDRA-12554:
-----------------------------------------
bq. Also we dont need to change the setRejectedExecutionHandler in
CASSANDRA-7390 as we can change the order of calling increment.
I don't believe this change is correct. With the {{DiscardPolicy}}, if the
runnable is rejected it will be silently discarded, so we'll increment the
counter but never decrement it.
Also, what branch is the patch based on?
> updateJobs in PendingRangeCalculatorService should be decremented in finally
> block
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-12554
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12554
> Project: Cassandra
> Issue Type: Bug
> Reporter: sankalp kohli
> Assignee: sankalp kohli
> Priority: Minor
> Attachments: PendingRangeRace.txt
>
>
> We fixed an issue in CASSANDRA-7390 with MoveTests by adding a count for
> running jobs. While looking at the code, I can see that decrement of this
> counter should be done in finally block.
> Also we dont need to change the setRejectedExecutionHandler in CASSANDRA-7390
> as we can change the order of calling increment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
