[ 
https://issues.apache.org/jira/browse/CASSANDRA-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495387#comment-15495387
 ] 

Geoffrey Yu commented on CASSANDRA-12367:
-----------------------------------------

Thanks for the first pass [~slebresne]! I added another commit to address your 
comments 
[here|https://github.com/geoffxy/cassandra/commit/a71968ebba8b67591b88cafd2daf3b37e17fec52].
 I added {{rowCount()}} to the {{Partition}} interface to be able to pass in a 
{{rowEstimate}} to {{UnfilteredRowIteratorSerializer.serializedSize()}} since 
all the implementing classes already had that method available. Please let me 
know how it looks now!

{quote}
Wonders if it wouldn't be more user friendly to return 0 if the key is not 
hosted on that replica (which will simply happen if we don't check anything). 
Genuine question though, I could see both options having advantages, so 
mentioning it for the sake of discussion.
{quote}

I don't feel strongly either way since I also agree that both options have 
merit. I've left the check in for now but I have no objection to removing it if 
others feel strongly.

> Add an API to request the size of a CQL partition
> -------------------------------------------------
>
>                 Key: CASSANDRA-12367
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12367
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Geoffrey Yu
>            Assignee: Geoffrey Yu
>            Priority: Minor
>             Fix For: 3.x
>
>         Attachments: 12367-trunk-v2.txt, 12367-trunk.txt
>
>
> It would be useful to have an API that we could use to get the total 
> serialized size of a CQL partition, scoped by keyspace and table, on disk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to