[ 
https://issues.apache.org/jira/browse/CASSANDRA-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502215#comment-15502215
 ] 

Stefania edited comment on CASSANDRA-9318 at 9/19/16 4:09 AM:
--------------------------------------------------------------

Thanks [~sbtourist], the latest commits and the entire patch LGTM.

The test failures are unrelated and we have tickets for all of them: 
CASSANDRA-12664, CASSANDRA-12656 and CASSANDRA-12140. I've launched one more 
dtest build to cover the final commit and to hopefully shake off the 
CASSANDRA-12656 failures since these tests shouldn't even be running now.

I've squashed your entire patch into [one 
commit|https://github.com/stef1927/cassandra/commit/1632f2e9892624f611ac3629fb84a82594fec726]
 and fixed some formatting issues (mostly trailing spaces) 
[here|https://github.com/stef1927/cassandra/commit/e3346e5f5a49b2933e10a84405730]
 on this [branch|https://github.com/stef1927/cassandra/commits/9318].

If you could double check the formatting nits, I can squash them and commit 
once the final dtest build has also completed. 


was (Author: stefania):
Thanks [~sbtourist], the latest commits and the entire patch LGTM.

The test failures are all unrelated and we have tickets for all of them: 
CASSANDRA-12664, CASSANDRA-12656 and CASSANDRA-12140. I've launched one more 
dtest build to cover the final commit and to hopefully shake off the 
CASSANDRA-12656 failures since these tests shouldn't even be running now.

I've squashed your entire patch into [one 
commit|https://github.com/stef1927/cassandra/commit/1632f2e9892624f611ac3629fb84a82594fec726]
 and fixed some formatting issues (mostly trailing spaces) 
[here|https://github.com/stef1927/cassandra/commit/e3346e5f5a49b2933e10a84405730]
 on this [branch|https://github.com/stef1927/cassandra/commits/9318].

If you could double check the formatting nits, I can squash them and commit 
once the final dtest build has also completed. 

> Bound the number of in-flight requests at the coordinator
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-9318
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9318
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths, Streaming and Messaging
>            Reporter: Ariel Weisberg
>            Assignee: Sergio Bossa
>         Attachments: 9318-3.0-nits-trailing-spaces.patch, backpressure.png, 
> limit.btm, no_backpressure.png
>
>
> It's possible to somewhat bound the amount of load accepted into the cluster 
> by bounding the number of in-flight requests and request bytes.
> An implementation might do something like track the number of outstanding 
> bytes and requests and if it reaches a high watermark disable read on client 
> connections until it goes back below some low watermark.
> Need to make sure that disabling read on the client connection won't 
> introduce other issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to