Aleksey Yeschenko commented on CASSANDRA-12516:

Patch LGTM, +1.

> Interned column identifiers can be overridden incorrectly
> ---------------------------------------------------------
>                 Key: CASSANDRA-12516
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12516
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Aleksey Yeschenko
>            Assignee: Stefania
>             Fix For: 3.0.x, 3.x
> As discovered by [~Stefania] in CASSANDRA-12423, our use of 
> {{ColumnIdentifier.internedInstances}} to map byte buffer column names to 
> column identifiers is incorrect. It's possible for two non-equal 
> {{ColumnIdentifier}} instances to have the same {{ByteBuffer}} as raw name, 
> and yet different text representations, due to different column name types, 
> leading to hard to debug correctness issues.
> Should either amend the map to have the type as part of the key, or limit the 
> use of that map.

This message was sent by Atlassian JIRA

Reply via email to