[ 
https://issues.apache.org/jira/browse/CASSANDRA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512472#comment-15512472
 ] 

Benjamin Lerer commented on CASSANDRA-12605:
--------------------------------------------

The patch looks good to me. Thanks.


> Timestamp-order searching of sstables does not handle non-frozen UDTs, frozen 
> collections correctly
> ---------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12605
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12605
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Tyler Hobbs
>            Assignee: Tyler Hobbs
>
> {{SinglePartitionReadCommand.queryNeitherCountersNorCollections()}} is used 
> to determine whether we can search sstables in timestamp order.  We cannot 
> use this optimization when there are multicell values (such as unfrozen 
> collections or UDTs).  However, this method only checks 
> {{column.type.isCollection() || column.type.isCounter()}}.  Instead, it 
> should check {{column.type.isMulticell() || column.type.isCounter()}}.
> This has two implications:
> * We are using timestamp-order searching when querying non-frozen UDTs, which 
> can lead to incorrect/stale results being returned.
> * We are not taking advantage of this optimization when querying frozen 
> collections.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to