[
https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531974#comment-15531974
]
Alex Petrov edited comment on CASSANDRA-12461 at 9/29/16 7:41 AM:
------------------------------------------------------------------
+1 on changes.
The initial patch was marked as a "bug", I've re-labeled it as an
"improvement". But since we have fixed several issues with drain process
([CASSANDRA-12509], for example), might be good to have it in 3.0? Or should I
remove hooks, only leave bugfix for 3.0 patch (will be a trivial change, too),
just don't want to create confusion..
Backport to 3.0 was trivial, but we can just skip committing if anything. CI
triggered for both branches (although your latest branch only squashed, without
any changes on top).
|[12461-trunk|https://github.com/ifesdjeen/cassandra/tree/12461-trunk]|[dtest|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-dtest/]|[utest|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-testall/]|
|[12461-3.0|https://github.com/ifesdjeen/cassandra/tree/12461-3.0]|[dtest|http://cassci.datastax.com/job/ifesdjeen-12461-3.0-dtest/]|[utest|http://cassci.datastax.com/job/ifesdjeen-12461-3.0-testall/]|
was (Author: ifesdjeen):
+1 on changes.
The initial patch was marked as a "bug", I've re-labeled it as an
"improvement". But since we have fixed several issues with drain process
([CASSANDRA-12509], for example), might be good to have it in 3.0? Or should I
remove hooks, only leave bugfix for 3.0 patch (will be a trivial change, too),
just don't want to create confusion..
Backport to 3.0 was trivial, but we can just skip committing if anything. CI
triggered for both branches (although your latest branch only squashed, without
any changes on top).
|[12461-trunk|https://github.com/ifesdjeen/cassandra/tree/12461-trunk]|[dtest|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-dtest/]|[utest|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-testall/]|
|[12461-trunk|https://github.com/ifesdjeen/cassandra/tree/12461-trunk]|[3.0|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-3.0/]|[utest|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-testall/]||[12461-3.0|https://github.com/ifesdjeen/cassandra/tree/12461-3.0]|[dtest|http://cassci.datastax.com/job/ifesdjeen-12461-3.0-dtest/]|[utest|http://cassci.datastax.com/job/ifesdjeen-12461-3.0-testall/]|
> Add hooks to StorageService shutdown
> ------------------------------------
>
> Key: CASSANDRA-12461
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12461
> Project: Cassandra
> Issue Type: Bug
> Reporter: Anthony Cozzie
> Assignee: Anthony Cozzie
> Fix For: 3.x
>
> Attachments:
> 0001-CASSANDRA-12461-add-C-support-for-shutdown-runnables.patch
>
>
> The JVM will usually run shutdown hooks in parallel. This can lead to
> synchronization problems between Cassandra, services that depend on it, and
> services it depends on. This patch adds some simple support for shutdown
> hooks to StorageService.
> This should nearly solve CASSANDRA-12011
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
