[
https://issues.apache.org/jira/browse/CASSANDRA-12598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542078#comment-15542078
]
Berenguer Blasi commented on CASSANDRA-12598:
---------------------------------------------
Sorry for the late reply, I am back online.
I sleep better knowing I've overloaded those methods as this effectively gives
you the {{BailErrorStrategy}} behaviour we're looking for 100% guaranteed. If
somebody calls any of these methods directly, some auto-generated code changes
to use them otherwise different than now, etc. It is more future proof overall
imo.
> BailErrorStragery alike for ANTLR grammar parsing
> -------------------------------------------------
>
> Key: CASSANDRA-12598
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12598
> Project: Cassandra
> Issue Type: Bug
> Components: CQL
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Fix For: 3.x
>
>
> CQL parsing is missing a mechanism similar to
> http://www.antlr.org/api/Java/org/antlr/v4/runtime/BailErrorStrategy.html
> This solves:
> - Stopping parsing instead of continuing when we've got already an error
> which is wasteful.
> - Any skipped java code tied to 'recovered' missing tokens might later cause
> java exceptions (think non-init variables, non incremented integers (div by
> zero), etc.) which will bubble up directly and will hide properly formatted
> error messages to the user with no indication on what went wrong at all. Just
> a cryptic NPE i.e
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
