[
https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547340#comment-15547340
]
Stefania commented on CASSANDRA-12461:
--------------------------------------
Thanks for rebasing. Committed to 3.X as
9fd0d0747bd46a09ec3567f4ec94fa3d63eca9aa and merged into trunk.
There were CI failures but they should all be accounted for, if we include the
dtest pr for CASSANDRA-12509, except perhaps for
{{SnitchConfigurationUpdateTest.test_rf_collapse_property_file_snitch}}, but it
passes locally and I really don't see how this patch would break it, since
without hooks this patch is a no-op. For trunk, testall is reported as a failed
build, but the only failed test is a failure that happens also on unpatched
trunk and I verified locally that there are no eclipse warnings or other
reasons for the build to be marked failed. Also, according to the console
[output|http://cassci.datastax.com/job/ifesdjeen-12461-trunk-testall/3/console],
it failed because of the timeout in long-test, which caused the single known
failure.
> Add hooks to StorageService shutdown
> ------------------------------------
>
> Key: CASSANDRA-12461
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12461
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Anthony Cozzie
> Assignee: Anthony Cozzie
> Fix For: 3.x
>
> Attachments:
> 0001-CASSANDRA-12461-add-C-support-for-shutdown-runnables.patch
>
>
> The JVM will usually run shutdown hooks in parallel. This can lead to
> synchronization problems between Cassandra, services that depend on it, and
> services it depends on. This patch adds some simple support for shutdown
> hooks to StorageService.
> This should nearly solve CASSANDRA-12011
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
