[
https://issues.apache.org/jira/browse/CASSANDRA-12705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555456#comment-15555456
]
Carl Yeksigian commented on CASSANDRA-12705:
--------------------------------------------
This looks good, but we use the string of the kind enum when we are persisting
the column definition; probably makes sense to keep that here as well.
Also, the CI was so dirty, it's hard to tell if there is anything wrong.
> Add column definition kind to system schema dropped columns
> -----------------------------------------------------------
>
> Key: CASSANDRA-12705
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12705
> Project: Cassandra
> Issue Type: Bug
> Components: Distributed Metadata
> Reporter: Stefania
> Assignee: Stefania
> Fix For: 4.0
>
>
> Both regular and static columns can currently be dropped by users, but this
> information is currently not stored in {{SchemaKeyspace.DroppedColumns}}. As
> a consequence, {{CFMetadata.getDroppedColumnDefinition}} returns a regular
> column and this has caused problems such as CASSANDRA-12582.
> We should add the column kind to {{SchemaKeyspace.DroppedColumns}} so that
> {{CFMetadata.getDroppedColumnDefinition}} can create the correct column
> definition. However, altering schema tables would cause inter-node
> communication failures during a rolling upgrade, see CASSANDRA-12236.
> Therefore we should wait for a full schema migration when upgrading to the
> next major version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
