[ 
https://issues.apache.org/jira/browse/CASSANDRA-12784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571415#comment-15571415
 ] 

Stefania edited comment on CASSANDRA-12784 at 10/13/16 9:37 AM:
----------------------------------------------------------------

bq. Since the same test is being done for a large vnode count for the Murmur 
partitioner, I have absolutely nothing against reducing the scope of the random 
version to no higher than 16 vnodes.

Thanks, I'll change the test accordingly.

bq. The flaky utility failure is caused by not catching the right error type 
for some junit versions. The fix is to include || AssertionFailedError in the 
catch in runCatchingAssertionError.

That's what I thought as well initially, but actually AssertionFailedError is a 
sub-class of AssertionError so that is not the reason. I verified in Intellij 
that if we call Assert.fail() in the same method, the exception is caught. I 
must admit I don't understand this yet, unless it really ran 5 times and it 
failed every time but the suppressed exceptions were not displayed. The trouble 
is that it is hard to reproduce. We can add more debug information and leave it 
until we can reproduce it.


was (Author: stefania):
bq. Since the same test is being done for a large vnode count for the Murmur 
partitioner, I have absolutely nothing against reducing the scope of the random 
version to no higher than 16 vnodes.

Thanks, I'll change the test accordingly.

bq. The flaky utility failure is caused by not catching the right error type 
for some junit versions. The fix is to include || AssertionFailedError in the 
catch in runCatchingAssertionError.

That's what I thought as well initially, but actually AssertionFailedError is a 
sub-class of AssertionError so that is not the reason. I verified in Intellij 
that if we call Assert.fail() in the same method, the exception is catched. I 
must admit I don't understand this yet, unless it really ran 5 times and it 
failed every time but the suppressed exceptions were not displayed. The trouble 
is that it is hard to reproduce. We can add more debug information and leave it 
until we can reproduce it.

> ReplicationAwareTokenAllocatorTest times out almost every time for 3.X and 
> trunk
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12784
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12784
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stefania
>            Assignee: Stefania
>             Fix For: 3.x
>
>         Attachments: ReplicationAwareTokenAllocatorTest.jfr.gz
>
>
> Example failure: 
> http://cassci.datastax.com/view/cassandra-3.X/job/cassandra-3.X_testall/lastCompletedBuild/testReport/org.apache.cassandra.dht.tokenallocator/ReplicationAwareTokenAllocatorTest/testNewClusterWithMurmur3Partitioner/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to