[ 
https://issues.apache.org/jira/browse/CASSANDRA-12784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574514#comment-15574514
 ] 

Branimir Lambov commented on CASSANDRA-12784:
---------------------------------------------

+1. Nits:

- The stack printout for single flakes could be useful to track the history of 
a failure; I would prefer not to lose it, but I wouldn't stop the commit if 
that is something you think is worth sacrificing.

- I would rename [{{flakyTestNewCluster}} in the base 
class|https://github.com/apache/cassandra/compare/trunk...stef1927:12784-3.X#diff-f32c9e3d5921a2a50fe56db4612f14b4R548]
 to just {{testNewCluster}} since the individual runner is the one that 
declares it flaky and handles that.

Is there a reason to post the the commits view instead of the [the branch 
one|https://github.com/stef1927/cassandra/tree/12784-3.X]? There's no direct 
way to get from the commits view to 
[compare|https://github.com/apache/cassandra/compare/trunk...stef1927:12784-3.X]
 which is the one most useful for reviews.



> ReplicationAwareTokenAllocatorTest times out almost every time for 3.X and 
> trunk
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12784
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12784
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stefania
>            Assignee: Stefania
>             Fix For: 3.x
>
>         Attachments: ReplicationAwareTokenAllocatorTest.jfr.gz
>
>
> Example failure: 
> http://cassci.datastax.com/view/cassandra-3.X/job/cassandra-3.X_testall/lastCompletedBuild/testReport/org.apache.cassandra.dht.tokenallocator/ReplicationAwareTokenAllocatorTest/testNewClusterWithMurmur3Partitioner/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to