Tyler Hobbs commented on CASSANDRA-11873:

+1 after the new changes, they look good.

bq. In my opinion having some checks will be probably less confusing for the 
user. With the current binary representation used for duration, the order will 
be completely random.

A completely random order is better than an almost-correct ordering, I think.  
In any case, it would be easy to go from the current restrictions to allowing 
durations to be used anywhere (but with random ordering) if we need to, so I 
think starting with this is fine.

bq. I did not tackle that part but I thought that there will be more work to do 
on the python driver side.

Ah, yes, you're correct.  We just need to make sure that driver work includes 
updating the reserved keywords, since that's easy to miss. (cc [~aholmber])

> Add duration type
> -----------------
>                 Key: CASSANDRA-11873
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11873
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>              Labels: client-impacting, doc-impacting
>             Fix For: 3.x
> For CASSANDRA-11871 or to allow queries with {{WHERE}} clause like:
> {{... WHERE reading_time < now() - 2h}}, we need to support some duration 
> type.
> In my opinion, it should be represented internally as a number of 
> microseconds.

This message was sent by Atlassian JIRA

Reply via email to