Kurt Greaves updated CASSANDRA-12788:
    Attachment: 12788-trunk.patch

Sounds reasonable to me. I've attached patch files for each branch.

> AbstractReplicationStrategy is not extendable from outside the package
> ----------------------------------------------------------------------
>                 Key: CASSANDRA-12788
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12788
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Kurt Greaves
>            Assignee: Kurt Greaves
>             Fix For: 3.0.x, 3.x
>         Attachments: 12788-3.0.patch, 12788-3.10.patch, 12788-trunk.patch, 
> 12788.patch
> The constructor for ARS is package-private (no modifier), which means that 
> custom RS implementations cannot call it. That is, calling super(...) fails 
> unless you create your replication strategy inside 
> org.apache.cassandra.locator. This obviously isn't ideal.
> I propose adding protected to the constructor in ARS. The attached patch was 
> against trunk however I believe it should work for 2.1, 2.2, 3.0, and 3.x.

This message was sent by Atlassian JIRA

Reply via email to